6b624a72cd
Replaced all 46 bare 'except:' across the package with specific exception
types, and logged the cases that indicate a real problem:
- config load/save: FileNotFoundError is the silent first-run case; other
OSError/ValueError/UnicodeDecodeError are logged.
- ffprobe/avprobe: JSON parse failures are now logged (previously a media
file that ffprobe couldn't read just silently failed to import); decode
fallbacks -> UnicodeDecodeError; duration parse -> ValueError/TypeError/
KeyError; install check -> OSError/SubprocessError.
- executor: pre_/post_function and progress-polling hooks now use hasattr
checks, and a real exception inside a defined hook is logged instead of
swallowed; decode fallbacks and numeric parses narrowed.
- best-effort filesystem ops (makedirs/unlink) -> OSError.
- all backend check_is_installed probes -> OSError/SubprocessError.
- shutdown: also fixes a latent NameError ('failure' was only set in the
except branch, so a successful logind PowerOff would crash the handler).
No bare 'except:' remain. Full suite (51 tests) green; GUI starts clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
59 lines
1.7 KiB
Python
59 lines
1.7 KiB
Python
# Copyright 2014 (C) Raster Software Vigo (Sergio Costas)
|
|
#
|
|
# This file is part of DeVeDe-NG
|
|
#
|
|
# DeVeDe-NG is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License version 3
|
|
# as published by the Free Software Foundation.
|
|
#
|
|
# DeVeDe-NG is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
|
|
import subprocess
|
|
import devedeng.configuration_data
|
|
import devedeng.executor
|
|
|
|
|
|
class vlc(devedeng.executor.executor):
|
|
|
|
supports_analize = False
|
|
supports_play = True
|
|
supports_convert = False
|
|
supports_menu = False
|
|
supports_mkiso = False
|
|
supports_burn = False
|
|
display_name = "VLC"
|
|
|
|
@staticmethod
|
|
def check_is_installed():
|
|
try:
|
|
handle = subprocess.Popen(
|
|
["vlc", "-h"], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
|
|
(stdout, stderr) = handle.communicate()
|
|
if 0 == handle.wait():
|
|
return True
|
|
else:
|
|
return False
|
|
except (OSError, subprocess.SubprocessError):
|
|
return False
|
|
|
|
def __init__(self):
|
|
|
|
devedeng.executor.executor.__init__(self)
|
|
self.config = devedeng.configuration_data.configuration.get_config()
|
|
|
|
def play_film(self, file_name):
|
|
|
|
command_line = ["vlc", "--play-and-exit", file_name]
|
|
self.launch_process(command_line)
|
|
|
|
def process_stdout(self, data):
|
|
return
|
|
|
|
def process_stderr(self, data):
|
|
return
|